Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce global checkpoint sync interval in disruption tests #38931

Merged
merged 3 commits into from
Feb 15, 2019

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Feb 14, 2019

We verify seq_no_stats is aligned between copies at the end of some disruption tests. Sometimes, the assertion assertSeqNos is tripped due to a lagged global checkpoint on replicas. This happens because the global checkpoint is synced 30 seconds (by default) after the last replication operation. This change reduces the global checkpoint sync-internal to 1s in the disruption tests.

Closes #38318
Closes #36789

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests v7.0.0 :Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. v8.0.0 v7.2.0 v6.6.2 labels Feb 14, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dnhatn
Copy link
Member Author

dnhatn commented Feb 15, 2019

Thanks @jasontedor @ywelsch!

@dnhatn dnhatn merged commit 4ffa9ae into elastic:master Feb 15, 2019
@dnhatn dnhatn deleted the sync-gcp branch February 15, 2019 18:40
dnhatn added a commit that referenced this pull request Feb 15, 2019
We verify seq_no_stats is aligned between copies at the end of some
disruption tests. Sometimes, the assertion `assertSeqNos` is tripped due
to a lagged global checkpoint on replicas. The global checkpoint on
replicas is lagged because we sync the global checkpoint 30 seconds (by
default) after the last replication operation. This change reduces the
global checkpoint sync-internal to 1s in the disruption tests.

Closes #38318
Closes #36789
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 15, 2019
* master:
  Address some CCR REST test case flakiness (elastic#38975)
  Edits to text in Completion Suggester doc (elastic#38980)
  SQL: doc polishing
  [DOCS] Fixes broken formatting
  SQL: Polish the rest chapter (elastic#38971)
  Remove `nGram` and  `edgeNGram` token filter names (elastic#38911)
  Add an exception throw if waiting on transport port file fails (elastic#37574)
  Improve testcluster distribution artifact handling (elastic#38933)
  Advance max_seq_no before add operation to Lucene (elastic#38879)
  Reduce global checkpoint sync interval in disruption tests (elastic#38931)
  [test] disable packaging tests for suse boxes
  Relax testStressMaybeFlushOrRollTranslogGeneration (elastic#38918)
  [DOCS] Edits warning in put watch API (elastic#38582)
  Fix serialization bug in ShardFollowTask after cutting this class over to extend from ImmutableFollowParameters.
  [DOCS] Updates methods for upgrading machine learning (elastic#38876)
dnhatn added a commit that referenced this pull request Feb 15, 2019
We verify seq_no_stats is aligned between copies at the end of some
disruption tests. Sometimes, the assertion `assertSeqNos` is tripped due
to a lagged global checkpoint on replicas. The global checkpoint on
replicas is lagged because we sync the global checkpoint 30 seconds (by
default) after the last replication operation. This change reduces the
global checkpoint sync-internal to 1s in the disruption tests.

Closes #38318
Closes #36789
dnhatn added a commit that referenced this pull request Feb 16, 2019
We verify seq_no_stats is aligned between copies at the end of some
disruption tests. Sometimes, the assertion `assertSeqNos` is tripped due
to a lagged global checkpoint on replicas. The global checkpoint on
replicas is lagged because we sync the global checkpoint 30 seconds (by
default) after the last replication operation. This change reduces the
global checkpoint sync-internal to 1s in the disruption tests.

Closes #38318
Closes #36789
dnhatn added a commit that referenced this pull request Feb 16, 2019
We verify seq_no_stats is aligned between copies at the end of some
disruption tests. Sometimes, the assertion `assertSeqNos` is tripped due
to a lagged global checkpoint on replicas. The global checkpoint on
replicas is lagged because we sync the global checkpoint 30 seconds (by
default) after the last replication operation. This change reduces the
global checkpoint sync-internal to 1s in the disruption tests.

Closes #38318
Closes #36789
ywelsch added a commit that referenced this pull request May 22, 2019
AbstractDisruptionTestCase set a lower global checkpoint sync interval setting, but this was ignored by
testAckedIndexing, which has led to spurious test failures

Relates #41068, #38931
ywelsch added a commit that referenced this pull request May 22, 2019
AbstractDisruptionTestCase set a lower global checkpoint sync interval setting, but this was ignored by
testAckedIndexing, which has led to spurious test failures

Relates #41068, #38931
ywelsch added a commit that referenced this pull request May 22, 2019
AbstractDisruptionTestCase set a lower global checkpoint sync interval setting, but this was ignored by
testAckedIndexing, which has led to spurious test failures

Relates #41068, #38931
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
AbstractDisruptionTestCase set a lower global checkpoint sync interval setting, but this was ignored by
testAckedIndexing, which has led to spurious test failures

Relates elastic#41068, elastic#38931
henningandersen pushed a commit that referenced this pull request Jun 20, 2019
AbstractDisruptionTestCase set a lower global checkpoint sync interval setting, but this was ignored by
testAckedIndexing, which has led to spurious test failures

Relates #41068, #38931
seut added a commit to crate/crate that referenced this pull request Aug 29, 2019
This should remove flakiness of the cluster disruption integration tests.
See elastic/elasticsearch#38931 and
elastic/elasticsearch@d49d9b5
seut added a commit to crate/crate that referenced this pull request Aug 29, 2019
This should remove flakiness of the cluster disruption integration tests.
See elastic/elasticsearch#38931 and
elastic/elasticsearch@d49d9b5
seut added a commit to crate/crate that referenced this pull request Aug 30, 2019
This should remove flakiness of the cluster disruption integration tests.
See elastic/elasticsearch#38931 and
elastic/elasticsearch@d49d9b5
mergify bot pushed a commit to crate/crate that referenced this pull request Aug 30, 2019
This should remove flakiness of the cluster disruption integration tests.
See elastic/elasticsearch#38931 and
elastic/elasticsearch@d49d9b5
mergify bot pushed a commit to crate/crate that referenced this pull request Aug 30, 2019
This should remove flakiness of the cluster disruption integration tests.
See elastic/elasticsearch#38931 and
elastic/elasticsearch@d49d9b5

(cherry picked from commit 724c075)

# Conflicts:
#	sql/src/main/java/io/crate/analyze/TableParameters.java
seut added a commit to crate/crate that referenced this pull request Aug 30, 2019
This should remove flakiness of the cluster disruption integration tests.
See elastic/elasticsearch#38931 and
elastic/elasticsearch@d49d9b5

(cherry picked from commit 724c075)

# Conflicts:
#	sql/src/main/java/io/crate/analyze/TableParameters.java
mergify bot pushed a commit to crate/crate that referenced this pull request Aug 30, 2019
This should remove flakiness of the cluster disruption integration tests.
See elastic/elasticsearch#38931 and
elastic/elasticsearch@d49d9b5

(cherry picked from commit 724c075)

# Conflicts:
#	sql/src/main/java/io/crate/analyze/TableParameters.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. >test Issues or PRs that are addressing/adding tests v6.6.2 v6.7.0 v7.0.0-rc2 v7.2.0 v8.0.0-alpha1
Projects
None yet
5 participants