[DATA-FRAME-ANALYTICS] Add task recovery on node change #39416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core |
benwtrent
commented
Feb 26, 2019
| @@ -100,6 +101,7 @@ task internalClusterTest(type: RandomizedTestingTask, | |||
| dependsOn: unitTest.dependsOn) { | |||
| include '**/*IT.class' | |||
| systemProperty 'es.set.netty.runtime.available.processors', 'false' | |||
| systemProperties 'java.security.policy': file("src/main/plugin-metadata/plugin-security-test.policy").absolutePath | |||
There was a problem hiding this comment.
I needed to add these two lines for the integration tests to run. Apparently, with how the internal cluster is built, the painless plugin is not included, so I included it, and add the requisite java security policy so that it can run.
If there is a better way (or if the tests are deemed unnecessary), then I will happily change this.
.../src/main/java/org/elasticsearch/xpack/ml/action/TransportStartDataFrameAnalyticsAction.java
Show resolved
Hide resolved
| * | ||
| * @return Set of Strings representing the result fields for the constructed analysis | ||
| */ | ||
| Set<String> getResultFields(); |
There was a problem hiding this comment.
I do think a better solution here is to have some known prefix for our result fields and which analyzer they satisfy.
Something like _ml_analysis_result.<analyzer>.<result-name>. But, that change is more substantial, opted for better planning and refactoring down the line when/if we make that change.
.../src/main/java/org/elasticsearch/xpack/ml/action/TransportStartDataFrameAnalyticsAction.java
Show resolved
Hide resolved
.../main/java/org/elasticsearch/xpack/ml/dataframe/extractor/DataFrameDataExtractorFactory.java
Outdated
Show resolved
Hide resolved
...gin/ml/src/test/java/org/elasticsearch/xpack/ml/integration/DataFrameAnalyticsManagerIT.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is fairly simple (for now) as we don't have any state to really recover. We simply need to check what the previous state was and take some simple actions ahead of time.