Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCS: skip empty search hits when minimizing round-trips #40098

Merged
merged 4 commits into from
Mar 18, 2019

Commits on Mar 15, 2019

  1. CCS: skip empty search hits when minimizing round-trips

    When minimizing round-trips, each cluster returns its own independent
    search response. In case sort by field and/or field collapsing were
    requested, when one cluster has no results to return, the information
    about the field that sorting was based on (SortField array) as well as
    the field (and the values) that collapsing was performed on are missing
    in the search response. That causes problems as we can't build the
    proper `TopDocs` instance which would need to be either `TopFieldDocs`
    or `CollapseTopFieldDocs`. The merge routine expects that all the top
    docs are of the same exact type which can't be guaranteed. Given that
    the problematic results are empty, hence have no impact on the final
    results, we can simply skip them.
    
    Closes elastic#40067
    javanna committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    12876b3 View commit details
    Browse the repository at this point in the history
  2. fix tests

    javanna committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    6c7a34a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    81c267f View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2019

  1. Configuration menu
    Copy the full SHA
    adb3b7b View commit details
    Browse the repository at this point in the history