Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: Fix classpath discovery on Java 10+ #40420

Merged
merged 1 commit into from
Mar 26, 2019
Merged

SQL: Fix classpath discovery on Java 10+ #40420

merged 1 commit into from
Mar 26, 2019

Conversation

costin
Copy link
Member

@costin costin commented Mar 25, 2019 •
edited
Loading

Makes #40388 work on Java 10+

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

matriv
matriv approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thx for the quick fix!

imotov
imotov approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@imotov imotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2. Thanks for the quick turnaround!

@costin
Copy link
Member Author

costin commented Mar 25, 2019 •
edited
Loading

run elasticsearch-ci/1

@costin
Copy link
Member Author

costin commented Mar 25, 2019 •
edited
Loading

run elasticsearch-ci/2
run elasticsearch-ci/bwc

@costin
Copy link
Member Author

costin commented Mar 25, 2019

run elasticsearch-ci/default-distro

astefan
astefan approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@astefan astefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@costin
Copy link
Member Author

costin commented Mar 25, 2019

run elasticsearch-ci/1

@costin costin merged commit 2cef233 into elastic:master Mar 26, 2019
@costin costin deleted the sql/classpath-scanning-2 branch March 26, 2019 06:17
costin added a commit that referenced this pull request Mar 26, 2019
@costin
SQL: Fix classpath discovery on Java 10+ (#40420)
7234d78 
(cherry picked from commit 2cef233)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imotov imotov imotov approved these changes

@astefan astefan astefan approved these changes

@matriv matriv matriv approved these changes

Assignees
No one assigned
Labels
:Analytics/SQL SQL querying >enhancement v7.2.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@costin @elasticmachine @imotov @astefan @matriv @jakelandis