Use TAR instead of DOCKER build type before 6.7.0 #40723
Conversation
In 6.7.0 (elastic#39378) we added a build type of DOCKER for the docker images, but unfortunately earlier versions do not understand this and will reject any transport messages that mention this build type. This commit fixes this by reporting TAR instead of DOCKER when talking to older nodes. Relates (but does not fix) elastic#40511 Relates elastic#39378
DaveCTurner
added
>bug
:Delivery/Build
|
Pinging @elastic/es-core-infra |
|
Thanks for finding the issue so quickly and addressing it @DaveCTurner. This is a really unfortunate issue, where changing an enumeration is not what we traditionally think of as a serialization-breaking change. Sadly, we did not have testing infrastructure in place here either, that could at least help us catch issues like this before shipping. |
jasontedor
added
blocker
:Delivery/Packaging
|
@rjernst do you think this is something the upgrade we do in the packaging tests would have caught? It doesn't seem to be the case, so non of the linked issues would have helped catch this. If this is indeed the case I think we should create a new one with what we think the solution to this problem is. To me it seems that randomizing the distribution type in rolling upgrade and full packaging tests would be the way to go ( either on a per test or on a per node basis ). This is something we can could consider for TestClusters. |
|
@atorok The upgrade tests we do in the packaging tests would not have caught this. Those are only a single-node full cluster restart. This issue arises in a mixed cluster only. |
In 6.7.0 (#39378) we added a build type of DOCKER for the docker images, but unfortunately earlier versions do not understand this and will reject any transport messages that mention this build type. This commit fixes this by reporting TAR instead of DOCKER when talking to older nodes. Relates (but does not fix) #40511 Relates #39378
In 6.7.0 (#39378) we added a build type of DOCKER for the docker images, but unfortunately earlier versions do not understand this and will reject any transport messages that mention this build type. This commit fixes this by reporting TAR instead of DOCKER when talking to older nodes. Relates (but does not fix) #40511 Relates #39378
|
thanks @jasontedor that's what I taught. I added #40732 |
In 6.7.0 (#39378) we added a build type of DOCKER for the docker images, but unfortunately earlier versions do not understand this and will reject any transport messages that mention this build type. This commit fixes this by reporting TAR instead of DOCKER when talking to older nodes. Relates (but does not fix) #40511 Relates #39378
In 6.7.0 (#39378) we added a build type of DOCKER for the docker images, but unfortunately earlier versions do not understand this and will reject any transport messages that mention this build type. This commit fixes this by reporting TAR instead of DOCKER when talking to older nodes. Relates (but does not fix) #40511 Relates #39378 This commit is the changes that were supposed to be included in the preceding one, abe509a, but weren't because of a missing `git add`.
In 6.7.0 (elastic#39378) we added a build type of DOCKER for the docker images, but unfortunately earlier versions do not understand this and will reject any transport messages that mention this build type. This commit fixes this by reporting TAR instead of DOCKER when talking to older nodes. Relates (but does not fix) elastic#40511 Relates elastic#39378
In 6.7.0 (#39378) we added a build type of DOCKER for the docker images, but
unfortunately earlier versions do not understand this and will reject any
transport messages that mention this build type.
This commit fixes this by reporting TAR instead of DOCKER when talking to older
nodes.
Relates (but does not fix) #40511
Relates #39378