-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit the number of forks getting Java versions #41386
Merged
jasontedor
merged 3 commits into
elastic:master
from
jasontedor:java-version-parallelization-limit
Apr 19, 2019
Merged
Limit the number of forks getting Java versions #41386
jasontedor
merged 3 commits into
elastic:master
from
jasontedor:java-version-parallelization-limit
Apr 19, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To reduce configuration time, we fork some threads to compute the Java version for the various configured Javas. However, as the number of JAVA${N}_HOME variable increases, the current implementation creates as many threads as there are such variables, which could be more than the number of physical cores on the machine. It is not likely that we would see benefits to trying to execute all of these once beyond the number of physical cores (maybe simultaneous multi-threading helps though, who knows. Therefore, this commit limits the parallelization here to the number number of physical cores.
jasontedor
added
>non-issue
:Delivery/Build
Build or test infrastructure
v8.0.0
v7.2.0
labels
Apr 19, 2019
Pinging @elastic/es-core-infra |
rjernst
approved these changes
Apr 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jasontedor
added a commit
that referenced
this pull request
Apr 19, 2019
To reduce configuration time, we fork some threads to compute the Java version for the various configured Javas. However, as the number of JAVA${N}_HOME variable increases, the current implementation creates as many threads as there are such variables, which could be more than the number of physical cores on the machine. It is not likely that we would see benefits to trying to execute all of these once beyond the number of physical cores (maybe simultaneous multi-threading helps though, who knows. Therefore, this commit limits the parallelization here to the number number of physical cores.
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
To reduce configuration time, we fork some threads to compute the Java version for the various configured Javas. However, as the number of JAVA${N}_HOME variable increases, the current implementation creates as many threads as there are such variables, which could be more than the number of physical cores on the machine. It is not likely that we would see benefits to trying to execute all of these once beyond the number of physical cores (maybe simultaneous multi-threading helps though, who knows. Therefore, this commit limits the parallelization here to the number number of physical cores.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Delivery/Build
Build or test infrastructure
>non-issue
Team:Delivery
Meta label for Delivery team
v7.2.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce configuration time, we fork some threads to compute the Java version for the various configured Javas. However, as the number of JAVA${N}_HOME variable increases, the current implementation creates as many threads as there are such variables, which could be more than the number of physical cores on the machine. It is not likely that we would see benefits to trying to execute all of these once beyond the number of physical cores (maybe simultaneous multi-threading helps though, who knows. Therefore, this commit limits the parallelization here to the number number of physical cores.
Relates #41251, relates #41379