Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes typed URLs from mapping APIs #41676

Merged
merged 15 commits into from Sep 23, 2019

Conversation

@colings86
Copy link
Member

commented Apr 30, 2019

No description provided.

@colings86 colings86 requested a review from jpountz Apr 30, 2019

@colings86 colings86 self-assigned this Apr 30, 2019

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Apr 30, 2019

@colings86 colings86 force-pushed the colings86:types-removal/mappings-urls branch from 066fcc1 to ff05a88 Apr 30, 2019

@jpountz jpountz referenced this pull request Apr 30, 2019
32 of 52 tasks complete

@colings86 colings86 force-pushed the colings86:types-removal/mappings-urls branch 12 times, most recently from fc45502 to f99480a Apr 30, 2019

@colings86 colings86 force-pushed the colings86:types-removal/mappings-urls branch from f99480a to a04aacc May 9, 2019

@colings86 colings86 force-pushed the colings86:types-removal/mappings-urls branch 2 times, most recently from 30e6f59 to e425aba May 20, 2019

@colings86

This comment has been minimized.

Copy link
Member Author

commented May 20, 2019

@elasticmachine run elasticsearch-ci/packaging-sample

@colings86 colings86 force-pushed the colings86:types-removal/mappings-urls branch 3 times, most recently from 63d9c5f to f7017cf May 21, 2019

@colings86

This comment has been minimized.

Copy link
Member Author

commented May 23, 2019

@elasticmachine run elasticsearch-ci/default-distro

@jpountz
Copy link
Contributor

left a comment

I left some questions/comments.

@colings86 colings86 force-pushed the colings86:types-removal/mappings-urls branch from 0ea6775 to 3b5e27c Jun 4, 2019

@colings86

This comment has been minimized.

Copy link
Member Author

commented Jun 4, 2019

@elasticmachine run elasticsearch-ci/2

colings86 added 4 commits Apr 30, 2019

@colings86 colings86 force-pushed the colings86:types-removal/mappings-urls branch from f2fba1e to 62832cc Jun 5, 2019

colings86 added 3 commits Jun 5, 2019

@colings86 colings86 force-pushed the colings86:types-removal/mappings-urls branch from f04066c to 8f4e017 Jun 10, 2019

@colings86 colings86 force-pushed the colings86:types-removal/mappings-urls branch from 8f4e017 to dd11be2 Jun 10, 2019

@colings86

This comment has been minimized.

Copy link
Member Author

commented Jun 10, 2019

@elasticmachine update branch

@colings86 colings86 requested a review from jpountz Jun 11, 2019

@jpountz
Copy link
Contributor

left a comment

LGTM, sorry I let it wait for a review for so long.

romseygeek added 2 commits Sep 12, 2019

@romseygeek romseygeek assigned romseygeek and unassigned colings86 Sep 12, 2019

@romseygeek

This comment has been minimized.

Copy link
Contributor

commented Sep 23, 2019

@elasticmachine run elasticsearch-ci/docs-check

@romseygeek romseygeek merged commit a574a66 into elastic:master Sep 23, 2019

9 checks passed

CLA All commits in pull request signed
Details
elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/bwc Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docs Build finished.
Details
elasticsearch-ci/docs-check Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.