SQL: Improve error messages for geo_shape #41923
Conversation
Improves error messages when geo_shapes are used in unsupported manner and adds description of current geo function limitations. Fixes elastic#41791
imotov
added
>enhancement
:Analytics/Geo
|
Pinging @elastic/es-analytics-geo |
|
Pinging @elastic/es-search |
| @@ -5,6 +5,18 @@ | |||
|
|
|||
| The geo functions work with geometries stored in `geo_point` and `geo_shape` fields, or returned by other geo functions. | |||
|
|
|||
| ==== Limitations | |||
There was a problem hiding this comment.
We have a Limitations page where various bits and pieces are listed in a central place: https://www.elastic.co/guide/en/elasticsearch/reference/master/sql-limitations.html
It's probably ok to list this limitation here, but I would like to see it listed in the general Limitations page, as well.
| @@ -773,4 +773,24 @@ public void testAggregateAliasInFilter() { | |||
| public void testProjectUnresolvedAliasInFilter() { | |||
| assertEquals("1:8: Unknown column [tni]", error("SELECT tni AS i FROM test WHERE i > 10 GROUP BY i")); | |||
| } | |||
|
|
|||
| public void testGeoShapeInWhereClause() { | |||
There was a problem hiding this comment.
Can you add one more test where all three unsupported scenarios take place? WHERE .... GROUP BY .... ORDER BY .... so that all three messages are logged.
There was a problem hiding this comment.
I would have to two other shape fields to the mapping for that. The failure messages are grouped by their source node, which is shape in this case. So, only one failure message would show up. Do you think it is worth adding other shape fields?
| @@ -582,8 +582,7 @@ public void testTranslateStAsWktForPoints() { | |||
| } | |||
|
|
|||
| public void testTranslateStAsWktForShapes() { | |||
There was a problem hiding this comment.
The method name should be changed, since it's only testing geo points.
There was a problem hiding this comment.
Good catch. It should be removed, actually. We already have a method that tests this for points.
…ng-of-geoshapes-and-doc-fields
…ng-of-geoshapes-and-doc-fields
|
@elasticmachine run elasticsearch-ci/1 |
Improves error messages when geo_shapes are used in unsupported manner
and adds description of current geo function limitations.
Fixes #41791