Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recursively Delete Unreferenced Index Directories #42189
Recursively Delete Unreferenced Index Directories #42189
Changes from 4 commits
09ec6f3
20a6720
273a165
aba91e1
ac3c496
e593e0c
de61d35
22a668e
3d7da2e
826e513
96dabb7
c0e025e
e99e5c0
0e66c19
e4aa770
a2bfa0f
98dc56c
372fd26
5eb036b
3d1e26b
cb2a196
2ca8c4c
908cfeb
2d0f368
d72cbcd
b9b4c32
8a82885
ae4c9a8
b8441ac
f50a895
014f5e0
f825d3f
2e0bd14
1c33d31
bb3fb73
def2d77
d6fa0fe
e7a3c2b
bb95f7f
9cac1a4
c8394fe
b338a91
a8bf18e
be8b479
58fcfe2
1e39e9b
5b5ddb2
dc62d64
c52a394
dea1a07
43bb00a
af47bb8
47766e1
81aab9b
deb73e3
b8a7067
c613d89
d841af4
e13d799
f384e9c
79478cb
bc1497e
421553b
b3478b5
bbb9632
26df577
7617660
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also mention current path here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this reads a bit funnily, maybe rephrase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why would we expect duplicates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, for some reason I just mindlessly copied that comment from the list by prefix method. It makes 0 sense imo, I'll just remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not just use
Files.isDirectory(file)
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jup ... this was just a left over from copying the logic of list by prefix, adjusting :)