Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add conditionals and escape quotes to render 'deprecated' macros in 'Core Types' docs for Asciidoctor migration #42236

Merged
merged 2 commits into from May 24, 2019
Merged

[DOCS] Add conditionals and escape quotes to render 'deprecated' macros in 'Core Types' docs for Asciidoctor migration #42236

merged 2 commits into from May 24, 2019

Conversation

jrodewig
Copy link
Contributor

Adds ifdef conditionals and escape quotes to correctly render deprecated macros for Asciidoctor. Relates to elastic/docs#827.

Plan to backport to 1.5

AsciiDoc Before

Before images AsciiDoc - Before A AsciiDoc - Before B

AsciiDoc After

After images AsciiDoc - After A AsciiDoc - After B

Asciidoctor Before

Before images Asciidoctor - Before A Asciidoctor - Before B

Asciidoctor After

After images Asciidoctor - After A Asciidoctor - After B

@jrodewig jrodewig added >docs General docs changes :Docs labels May 20, 2019
@jrodewig jrodewig requested a review from nik9000 May 20, 2019 15:42
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

@jrodewig jrodewig merged commit d121e2f into elastic:1.7 May 24, 2019
@jrodewig jrodewig deleted the asciidoctor-mapping-core-types-1.7 branch May 24, 2019 19:07
jrodewig added a commit that referenced this pull request May 24, 2019
…os in 'Core Types' docs for Asciidoctor migration (#42236)
jrodewig added a commit that referenced this pull request May 24, 2019
…os in 'Core Types' docs for Asciidoctor migration (#42236)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants