-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log write failures for watcher history document. #44129
Merged
jakelandis
merged 3 commits into
elastic:master
from
jakelandis:log_watch_history_failures
Jul 15, 2019
Merged
Log write failures for watcher history document. #44129
jakelandis
merged 3 commits into
elastic:master
from
jakelandis:log_watch_history_failures
Jul 15, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The failure is correctly getting propagated, this commit adds support to explicitly look for .watch-history failures using the same logging strategy as triggered watch failures.
Pinging @elastic/es-core-features |
jakelandis
changed the title
Expose failures to write to watcher history document.
Log write failures for watcher history document.
Jul 9, 2019
hub-cap
approved these changes
Jul 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just one question about the if / else
x-pack/plugin/watcher/src/main/java/org/elasticsearch/xpack/watcher/Watcher.java
Outdated
Show resolved
Hide resolved
@elasticmachine update branch |
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Jul 15, 2019
The failure is correctly getting propagated, this commit adds support to explicitly look for .watch-history failures using the same logging strategy as triggered watch failures.
jakelandis
added a commit
that referenced
this pull request
Jul 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failure is correctly getting propagated, however, it is ignored.
This commit adds support to explicitly look for .watch-history failures
using the same logging strategy as triggered watch failures.
This is pretty difficult to add a test (and the change is just an additional log message).
To test manually...
add
"index.mapping.total_fields.limit" : "150"
towatch-history-no-ilm.json
and/orwatch-history.json
inx-pack/plugin/core/src/main/resources
create a watch that will add a bunch of mappings
The error will now be displayed in log and will look like:
To see the mapping error from the origin, you can set