-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert BucketScript to static parser #44385
Convert BucketScript to static parser #44385
Conversation
BucketScript was using the old-style parser and could easily be converted over to the newer static parser. Also adds a test for GapPolicy enum serialization
Pinging @elastic/es-analytics-geo |
@elasticmachine update branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BucketScript was using the old-style parser and could easily be converted over to the newer static parser. Also adds a test for GapPolicy enum serialization
We're seeing issues with Kibana that we have tracked back to this commit.
Here is an example of a query throwing the exception:
Is there an intentional breaking change here, or something we should be doing differently in this Timelion request? |
This is not an intentional break. I have opened a PR toads back the possibility of defining |
I was wanting to make some changes to BucketScript to support "empty" buckets, but the old style parser was getting in the way. This converts it over to the new(er) static parser. It also adds a test for GapPolicy enum serialization since that was lacking.