Support BucketScript paths of type string and array. #44694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimczi
approved these changes
Jul 22, 2019
| .endObject() | ||
| .endObject(); | ||
| BucketScriptPipelineAggregationBuilder builder1 = BucketScriptPipelineAggregationBuilder.parse("count", createParser(content)); | ||
| assertEquals(builder1.getBucketsPaths().length , 1); |
There was a problem hiding this comment.
maybe check the content too ?
| .endObject() | ||
| .endObject(); | ||
| BucketScriptPipelineAggregationBuilder builder2 = BucketScriptPipelineAggregationBuilder.parse("count", createParser(content)); | ||
| assertEquals(builder2.getBucketsPaths().length , 2); |
|
@elasticmachine run elasticsearch-ci/1 elasticsearch-ci/2 |
|
@elasticmachine run elasticsearch-ci/2 |
1 similar comment
|
@elasticmachine run elasticsearch-ci/2 |
|
Thanks for putting this up. I will verify this also resolves our issue in Kibana. |
|
Verified Kibana CI is passing with these changes: elastic/kibana#41701 (comment) |
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Jul 23, 2019
iverase
added a commit
that referenced
this pull request
Jul 23, 2019
|
@tylersmalley Thanks for checking! PR has been merged in master and 7.x. |
This was referenced Jul 23, 2019
polyfractal
pushed a commit
to polyfractal/elasticsearch
that referenced
this pull request
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #44385 the BucketScript parser was refactor to make it static. Unfortunately this action break some behaviour, in particular it is not able to parse paths defined as a String or an array. This PR gives back that ability.