Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types field in JSON Search Slow Logs #44641

Merged
merged 2 commits into from
Jul 22, 2019

Conversation

pgomulka
Copy link
Contributor

@pgomulka pgomulka commented Jul 19, 2019

The field has to be defined in log4j2.properties and should be an
escaped JSON for now (it is a broken JSON at the moment). This should later be refactored into a JSON array
of strings.
"types": "[\"type1\", \"type2\"]",

{
  "type": "index_search_slowlog",
  "timestamp": "2019-07-22T10:36:07,942+02:00",
  "level": "WARN",
  "component": "i.s.s.query",
  "cluster.name": "distribution_run",
  "node.name": "node-0",
  "message": "[index6][0]",
  "took": "8.9ms",
  "took_millis": "8",
  "total_hits": "0 hits",
  "types": "[\"type1\", \"type2\"]",
  "stats": "[]",
  "search_type": "QUERY_THEN_FETCH",
  "total_shards": "1",
  "source": "{}",
  "id": "ASDF",
  "cluster.uuid": "PkkHdglrTiiWfIE_0V4xWA",
  "node.id": "LFhU0lQaRNmxQPewPk0l7w"
}

The field has to be defined in log4j2.properties and should be an
escaped JSON for now. This should later be refactored into a JSON array
of strings.
@pgomulka pgomulka added :Core/Infra/Logging Log management and logging utilities v7.4.0 labels Jul 19, 2019
@pgomulka pgomulka self-assigned this Jul 19, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Contributor

@alpar-t alpar-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgomulka pgomulka merged commit 09e9c4c into elastic:7.x Jul 22, 2019
@colings86 colings86 added the >bug label Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Core/Infra/Logging Log management and logging utilities v7.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants