Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add is_write_index column to cat.aliases #44772

Merged
merged 10 commits into from
Aug 21, 2019
Merged

Add is_write_index column to cat.aliases #44772

merged 10 commits into from
Aug 21, 2019

Conversation

talevy
Copy link
Contributor

@talevy talevy commented Jul 23, 2019

Aliases have had the option to set is_write_index since 6.4,
but the cat.aliases action was never updated.

example:

alias            index                              filter routing.index routing.search  is_write_index
filebeat-7.0.1   filebeat-7.0.1-2019.07.23-000011   -      -             -               -
metricbeat-7.0.1 metricbeat-7.0.1-2019.07.23-000005 -      -             -               true
metricbeat-7.0.1 metricbeat-7.0.1-2019.07.21-000003 -      -             -               false

@talevy
Add is_write_index column to cat.aliases
3339dc9 
Aliases have had the option to set `is_write_index` since 6.4,
but the cat.aliases action was never updated.
@talevy talevy added >bug :Core/Infra/REST API REST infrastructure and utilities v8.0.0 v7.4.0 labels Jul 23, 2019
@talevy talevy requested a review from gwbrown July 23, 2019 19:27
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

gwbrown
gwbrown approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@gwbrown gwbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (assuming CI is happy), thanks @talevy!

@talevy
Copy link
Contributor Author

talevy commented Aug 5, 2019

run elasticsearch-ci/bwc

gwbrown
gwbrown approved these changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@gwbrown gwbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM - I don't love the duplication of the test cases, but I don't know of a better way to do it either.

@talevy
Copy link
Contributor Author

talevy commented Aug 5, 2019

thanks Gordon

run elasticsearch-ci/bwc
run elasticsearch-ci/default-distro

@talevy talevy merged commit 7106288 into elastic:master Aug 21, 2019
@talevy talevy deleted the cat-alias-write branch August 21, 2019 14:40
@talevy talevy mentioned this pull request Aug 21, 2019
Merged
talevy added a commit to talevy/elasticsearch that referenced this pull request Aug 21, 2019
@talevy
disable bwc tests for elastic#44772
380646a
@talevy talevy mentioned this pull request Aug 21, 2019
Merged
talevy added a commit that referenced this pull request Aug 21, 2019
@talevy
disable bwc tests for #44772 (#45816)
5493613
talevy added a commit that referenced this pull request Aug 21, 2019
@talevy
[7.x] Add is_write_index column to cat.aliases (#45798)
9b14b72 
* Add is_write_index column to cat.aliases (#44772)

Aliases have had the option to set `is_write_index` since 6.4,
but the cat.aliases action was never updated.

* correct version bounds to 7.4
@talevy talevy mentioned this pull request Aug 21, 2019
Merged
@bizybot bizybot mentioned this pull request Aug 28, 2019
Closed
@codebrain codebrain mentioned this pull request Oct 14, 2019
Closed
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwbrown gwbrown gwbrown approved these changes

Assignees
No one assigned
Labels
>bug :Core/Infra/REST API REST infrastructure and utilities v7.4.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@talevy @elasticmachine @gwbrown @jakelandis