Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove leniency during replay translog in peer recovery #44989

Merged
merged 3 commits into from
Jul 30, 2019

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Jul 30, 2019

Translog operations replayed during peer recovery should never fail. This change removes leniency in InternalEngine during replaying translog in peer recovery.

@dnhatn dnhatn added >bug :Distributed/Engine Anything around managing Lucene and the Translog in an open shard. v8.0.0 v7.4.0 labels Jul 30, 2019
@dnhatn dnhatn requested a review from ywelsch July 30, 2019 02:06
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn
Copy link
Member Author

dnhatn commented Jul 30, 2019

Thanks @ywelsch.

@dnhatn dnhatn merged commit 0b9b91a into elastic:master Jul 30, 2019
@dnhatn dnhatn deleted the peer-recovery-leniency branch July 30, 2019 14:15
dnhatn added a commit that referenced this pull request Jul 30, 2019
This change removes leniency in InternalEngine during replaying translog
in peer recovery.
jkakavas pushed a commit that referenced this pull request Jul 31, 2019
This change removes leniency in InternalEngine during replaying translog
in peer recovery.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Distributed/Engine Anything around managing Lucene and the Translog in an open shard. v7.4.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants