Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Reformats validate API #46389

Merged
merged 9 commits into from
Sep 18, 2019
Merged

Conversation

szabosteve
Copy link
Contributor

@szabosteve szabosteve commented Sep 5, 2019

Relates to elastic/docs#937 and #45621.

This PR updates the validate API to align with the new API reference template.

Depends on: #46377 (it adds query to the common params list.)

Resources:

@szabosteve szabosteve added the >docs General docs changes label Sep 5, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments that should fix the CI. Thanks!

@szabosteve
Copy link
Contributor Author

@elasticmachine test this please

@@ -202,7 +263,8 @@ GET twitter/_validate/query?rewrite=true&all_shards=true
}
--------------------------------------------------

Response:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prior snippet needs // TEST[continued].

Copy link
Contributor Author

@szabosteve szabosteve Sep 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrodewig Thank you so much, it solved the problem! Please approve when you have time.

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szabosteve szabosteve merged commit e0b19a8 into elastic:master Sep 18, 2019
@szabosteve szabosteve deleted the reformat.validate branch September 18, 2019 12:29
szabosteve added a commit to szabosteve/elasticsearch that referenced this pull request Sep 18, 2019
* [DOCS] Reformats validate API.
Co-Authored-By: James Rodewig <james.rodewig@elastic.co>
szabosteve added a commit to szabosteve/elasticsearch that referenced this pull request Sep 18, 2019
* [DOCS] Reformats validate API.
Co-Authored-By: James Rodewig <james.rodewig@elastic.co>
szabosteve added a commit to szabosteve/elasticsearch that referenced this pull request Sep 18, 2019
* [DOCS] Reformats validate API.
Co-Authored-By: James Rodewig <james.rodewig@elastic.co>
@szabosteve
Copy link
Contributor Author

Backported to 7.x, 7.4, and 7.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants