Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Reformats count API #46377

Merged
merged 9 commits into from
Sep 17, 2019
Merged

Conversation

szabosteve
Copy link
Contributor

Relates to elastic/docs#937 and #45621.

This PR updates the count API to align with the new API reference template.

Resources:

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

@jrodewig jrodewig mentioned this pull request Sep 5, 2019
14 tasks
@polyfractal polyfractal added v7.3.3 and removed v7.3.2 labels Sep 6, 2019
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments that should help fix the CI.

szabosteve and others added 7 commits September 16, 2019 17:58
Co-Authored-By: James Rodewig <james.rodewig@elastic.co>
Co-Authored-By: James Rodewig <james.rodewig@elastic.co>
Co-Authored-By: James Rodewig <james.rodewig@elastic.co>
Co-Authored-By: James Rodewig <james.rodewig@elastic.co>
Co-Authored-By: James Rodewig <james.rodewig@elastic.co>
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few minor comments but generally LGTM.

Co-Authored-By: James Rodewig <james.rodewig@elastic.co>
@szabosteve szabosteve merged commit 4e11a19 into elastic:master Sep 17, 2019
@szabosteve szabosteve deleted the reformat.count branch September 17, 2019 07:53
szabosteve added a commit to szabosteve/elasticsearch that referenced this pull request Sep 17, 2019
* [DOCS] Reformats count API.
Co-Authored-By: James Rodewig <james.rodewig@elastic.co>
szabosteve added a commit to szabosteve/elasticsearch that referenced this pull request Sep 17, 2019
* [DOCS] Reformats count API.
Co-Authored-By: James Rodewig <james.rodewig@elastic.co>
szabosteve added a commit to szabosteve/elasticsearch that referenced this pull request Sep 17, 2019
* [DOCS] Reformats count API.
Co-Authored-By: James Rodewig <james.rodewig@elastic.co>
@szabosteve
Copy link
Contributor Author

Backported to 7.x, 7.4, and 7.3.

@colings86 colings86 added v7.4.0 and removed v7.4.1 labels Sep 20, 2019
jkakavas pushed a commit to jkakavas/elasticsearch that referenced this pull request Sep 25, 2019
* [DOCS] Reformats count API.
Co-Authored-By: James Rodewig <james.rodewig@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants