Fix highlighting for script_score query #46507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayya-sharipova
added
the
:Search/Search
|
Pinging @elastic/es-search |
mayya-sharipova
added
:Search Relevance/Highlighting
jtibshirani
reviewed
Sep 9, 2019
| "Script Score With Highlight": | ||
| - skip: | ||
| version: " - 7.4.99" | ||
| reason: "highlight for script_score was introduce in 7.5" |
There was a problem hiding this comment.
Small typo: introduce -> introduced. Also, should this be 7.99.99 for now since it won't be available on 7.5 until it's backported?
There was a problem hiding this comment.
@jtibshirani Thanks for the review. I have changed the version to 7.4.1.
should this be 7.99.99 for now since it won't be available on 7.5 until it's backported?
Looks like there are no bwc tests for modules:lang-painless, as the build passed. But I am going to backport the change immediately after the merge to master.
jtibshirani
approved these changes
Sep 9, 2019
| --- | ||
| "Script Score With Highlight": | ||
| - skip: | ||
| version: " - 7.4.09" |
There was a problem hiding this comment.
I think this should just be - 7.4.0?
There was a problem hiding this comment.
@jtibshirani thanks, corrected in the last commit
mayya-sharipova
added a commit
that referenced
this pull request
Sep 10, 2019
mayya-sharipova
added a commit
that referenced
this pull request
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #46471