add doc_values mapping option to geo_shape field mapping
#47519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds TypeParsers.parseField to the fieldType parsing in AbstractGeometryFieldMapper. This enables support for common mapping configuration options like `copy_to`, `doc_values`, `store`, `index`, `index_options`. some options are not necessarily used, but all MappedFieldTypes recognize them: `similarity`, `boost`.
talevy
added
the
:Analytics/Geo
|
Pinging @elastic/es-analytics-geo (:Analytics/Geo) |
imotov
reviewed
Oct 9, 2019
|
+1 to add tests to the different options. |
|
ah, thanks for the reviews. I didn't realize more had to be implemented on that front. thought all the copy_to behavior would be inherited |
talevy
changed the title
doc_values mapping option to geo_shape field mapping
|
Hi Igor, after re-visiting this / forgetting about it... I realize that it is unclear how to support other options that TypeParsers supports like |
imotov
reviewed
Jan 7, 2020
server/src/test/java/org/elasticsearch/index/mapper/LegacyGeoShapeFieldMapperTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/index/mapper/GeoShapeFieldMapperTests.java
Outdated
Show resolved
Hide resolved
talevy
added a commit
that referenced
this pull request
Feb 24, 2020
This PR adds support for the `doc_values` field mapping parameter. `true` and `false` supported by the GeoShapeFieldMapper, only `false` is supported by the LegacyGeoShapeFieldMapper. relates #37206
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
doc_valuesfield mapping parameter.trueandfalsesupported by the GeoShapeFieldMapper,only
falseis supported by the LegacyGeoShapeFieldMapper.relates #37206