Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APM system_user #47668

Merged
merged 5 commits into from
Dec 6, 2019
Merged

APM system_user #47668

merged 5 commits into from
Dec 6, 2019

Conversation

cachedout
Copy link
Contributor

This is a fix for the issue described here: elastic/apm-server#2708

This extends changes made here to the apm_system user: #40876

(This was re-opened against master per a comment by @jakelandis in #47302)

@cachedout cachedout changed the title Apm system monitoring 8 APM system_user Oct 7, 2019
@jakelandis jakelandis added :Data Management/Monitoring :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC labels Oct 7, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Monitoring)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (:Security/Authorization)

@jakelandis
Copy link
Contributor

Changes look good, however, I would like a review from @elastic/es-security before merging and backporting.

@tomcallahan tomcallahan added v7.4.2 and removed v7.4.1 labels Oct 22, 2019
@polyfractal polyfractal added v7.4.3 and removed v7.4.2 labels Oct 31, 2019
@jimczi jimczi added v7.6.0 and removed v7.5.0 labels Nov 12, 2019
@cachedout
Copy link
Contributor Author

Hi @bizybot. Could you please take a look at the latest changes and see if they align with your suggestions? Thanks!

@bizybot
Copy link
Contributor

bizybot commented Nov 20, 2019

Hi @bizybot. Could you please take a look at the latest changes and see if they align with your suggestions? Thanks!

Ping @tvernum so this is not missed. Thank you.

@tvernum tvernum self-requested a review November 21, 2019 01:05
@cachedout
Copy link
Contributor Author

cachedout commented Dec 2, 2019

@tvernum Polite bump on review. Thanks!

@tvernum
Copy link
Contributor

tvernum commented Dec 5, 2019

@elasticmachine update branch

@tvernum
Copy link
Contributor

tvernum commented Dec 5, 2019

This looks good to me, once we get the tests passing.
I'll aim to keep an eye on it, and see if I can help sort out any issues for you.

@cachedout cachedout merged commit b7c6e82 into elastic:master Dec 6, 2019
@cachedout cachedout deleted the apm_system_monitoring_8 branch December 6, 2019 12:28
cachedout added a commit to cachedout/elasticsearch that referenced this pull request Dec 6, 2019
* Add test for APM beats index perms

* Grant monitoring index privs to apm_system user

* Review feedback

* Fix compilation problem
cachedout added a commit to cachedout/elasticsearch that referenced this pull request Dec 6, 2019
* Add test for APM beats index perms

* Grant monitoring index privs to apm_system user

* Review feedback

* Fix compilation problem
cachedout added a commit that referenced this pull request Dec 9, 2019
* Add test for APM beats index perms

* Grant monitoring index privs to apm_system user

* Review feedback

* Fix compilation problem
cachedout added a commit that referenced this pull request Dec 9, 2019
* Add test for APM beats index perms

* Grant monitoring index privs to apm_system user

* Review feedback

* Fix compilation problem
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
* Add test for APM beats index perms

* Grant monitoring index privs to apm_system user

* Review feedback

* Fix compilation problem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants