Add cloudId builder to the HLRC #47868
Conversation
Elastic cloud has a concept of a cloud Id. This Id is a base64 encoded url, split up into a few parts. This commit allows the user to pass in a cloud id now, which is translated to a HttpHost that is defined by the encoded parts therein.
hub-cap
added
>enhancement
:Clients/Java Low Level REST Client
|
Pinging @elastic/es-core-features (:Core/Features/Java Low Level REST Client) |
|
@elasticmachine run elasticsearch-ci/1 |
|
@elasticmachine run elasticsearch-ci/default-distro |
| // once decoded the parts are separated by a $ character | ||
| String[] decodedParts = decoded.split("\\$"); | ||
| if (decodedParts.length != 3) { | ||
| throw new IllegalStateException("cloudId " + cloudId + " did not contain the correct number of parts"); |
There was a problem hiding this comment.
This error will be really confusing for users who have no idea that cloudIds contain multiple parts, or that they are even encoded at all. Maybe we can change it to something like:
"clouldId ... is invalid and does not decode to a cluster identifier correctly"
There was a problem hiding this comment.
well the cloudID is masked for the user. It would be a copy/paste issue since these are generated and displayed in the UI for a user. But i can change it for sure.
| @@ -119,6 +120,32 @@ | |||
| setNodes(nodes); | |||
| } | |||
|
|
|||
| /** | |||
| * Returns a new {@link RestClientBuilder} to help with {@link RestClient} creation. | |||
| * Creates a new builder instance and sets the nodes that the client will send requests to. | |||
There was a problem hiding this comment.
I think adding an example of what a cloudId looks like to the javadoc would help for people who don't know what that is.
| // there is an optional first portion of the cloudId that is a human readable string, but it is not used. | ||
| if (cloudId.contains(":")) { | ||
| if (cloudId.indexOf(":") == cloudId.length() - 1) { | ||
| throw new IllegalStateException("cloudId " + cloudId + " is invalid"); |
There was a problem hiding this comment.
| throw new IllegalStateException("cloudId " + cloudId + " is invalid"); | |
| throw new IllegalStateException("cloudId " + cloudId + " is invalid, it cannot end with a ':'"); |
Elastic cloud has a concept of a cloud Id. This Id is a base64 encoded url, split up into a few parts. This commit allows the user to pass in a cloud id now, which is translated to a HttpHost that is defined by the encoded parts therein.
Elastic cloud has a concept of a cloud Id. This Id is a base64 encoded
url, split up into a few parts. This commit allows the user to pass in a
cloud id now, which is translated to a HttpHost that is defined by the
encoded parts therein.