Add ingest info to Cluster Stats #48485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talevy
added
>enhancement
:Data Management/Stats
|
Pinging @elastic/es-core-features (:Core/Features/Ingest) |
|
run elasticsearch-ci/bwc |
martijnvg
reviewed
Oct 28, 2019
server/src/main/java/org/elasticsearch/action/admin/cluster/stats/ClusterStatsNodes.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/admin/cluster/stats/ClusterStatsNodes.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/admin/cluster/stats/ClusterStatsNodes.java
Outdated
Show resolved
Hide resolved
talevy
added a commit
to talevy/elasticsearch
that referenced
this pull request
Oct 30, 2019
This commit creates random NodesStats until IngestStats is not null, so that it can be properly tested. This is done as to not change the existing behavior of createNodesStats since it depends on IngestStats being null at times for serialization testing purposes. I think it is OK to do this since it is unlikely that it will be null. relates elastic#48485 closes elastic#48684
talevy
added a commit
that referenced
this pull request
Oct 31, 2019
This commit creates random NodesStats until IngestStats is not null, so that it can be properly tested. This is done as to not change the existing behavior of createNodesStats since it depends on IngestStats being null at times for serialization testing purposes. I think it is OK to do this since it is unlikely that it will be null. relates #48485 closes #48684
talevy
added a commit
to talevy/elasticsearch
that referenced
this pull request
Oct 31, 2019
after backporting elastic#48485 in elastic#48661, version guards in master can be updated from 8.0 to 7.6 for IngestStats serialization guards
talevy
added a commit
to talevy/elasticsearch
that referenced
this pull request
Oct 31, 2019
this disables bwc tests for changes made in elastic#48485, that are being backported in elastic#48661. This will be reverted once elastic#48768 is merged.
Merged
talevy
added a commit
that referenced
this pull request
Oct 31, 2019
talevy
added a commit
that referenced
this pull request
Oct 31, 2019
* Add ingest info to Cluster Stats (#48485) This commit enhances the ClusterStatsNodes response to include global processor usage stats on a per-processor basis. example output: ``` ... "processor_stats": { "gsub": { "count": 0, "failed": 0 "current": 0 "time_in_millis": 0 }, "script": { "count": 0, "failed": 0 "current": 0, "time_in_millis": 0 } } ... ``` The purpose for this enhancement is to make it easier to collect stats on how specific processors are being used across the cluster beyond the current per-node usage statistics that currently exist in node stats. Closes #46146. * fix BWC of ingest stats The introduction of processor types into IngestStats had a bug. It was set to `null` and set as the key to the map. This would throw a NPE. This commit resolves this by setting all the processor types from previous versions that are not serializing it out to `_NOT_AVAILABLE`.
debadair
pushed a commit
to debadair/elasticsearch
that referenced
this pull request
Nov 13, 2019
This commit creates random NodesStats until IngestStats is not null, so that it can be properly tested. This is done as to not change the existing behavior of createNodesStats since it depends on IngestStats being null at times for serialization testing purposes. I think it is OK to do this since it is unlikely that it will be null. relates elastic#48485 closes elastic#48684
debadair
pushed a commit
to debadair/elasticsearch
that referenced
this pull request
Nov 13, 2019
this disables bwc tests for changes made in elastic#48485, that are being backported in elastic#48661. This will be reverted once elastic#48768 is merged.
debadair
pushed a commit
to debadair/elasticsearch
that referenced
this pull request
Nov 13, 2019
…stic#48768) * update IngestStats version guards to 7.6 after backporting elastic#48485 in elastic#48661, version guards in master can be updated from 8.0 to 7.6 for IngestStats serialization guards * forward port bwc tests in ingeststats * fix null ingeststats when reading the stream * re-enable bwc tests
This was referenced Feb 3, 2020
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Feb 21, 2020
Mpdreamz
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Feb 21, 2020
github-actions bot
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Feb 21, 2020
Mpdreamz
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Feb 21, 2020
Relates: #4341, elastic/elasticsearch#48485 Co-authored-by: Russ Cam <russ.cam@elastic.co>
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Feb 23, 2020
Relates: #4341, elastic/elasticsearch#48485 (cherry picked from commit 58bca4d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the ClusterStatsNodes response to include global
processor usage stats on a per-processor basis.
example output:
The purpose for this enhancement is to make it easier to collect stats on how specific processors are being used across the cluster beyond the current per-node usage statistics that currently exist in node stats.
Closes #46146.