[7.x] Add ingest info to Cluster Stats (#48485) #48661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enhances the ClusterStatsNodes response to include global
processor usage stats on a per-processor basis.
example output:
```
...
"processor_stats": {
"gsub": {
"count": 0,
"failed": 0
"current": 0
"time_in_millis": 0
},
"script": {
"count": 0,
"failed": 0
"current": 0,
"time_in_millis": 0
}
}
...
```
The purpose for this enhancement is to make it easier to collect stats on how specific processors are being used across the cluster beyond the current per-node usage statistics that currently exist in node stats.
Closes elastic#46146.
The introduction of processor types into IngestStats had a bug. It was set to `null` and set as the key to the map. This would throw a NPE. This commit resolves this by setting all the processor types from previous versions that are not serializing it out to `_NOT_AVAILABLE`.
|
hey @martijnvg, I asked for a review for this backport because of the second commit. I missed this in the original PR. When fetching node stats from pre-7.6 nodes, the type will be |
talevy
added a commit
to talevy/elasticsearch
that referenced
this pull request
Oct 31, 2019
after backporting elastic#48485 in elastic#48661, version guards in master can be updated from 8.0 to 7.6 for IngestStats serialization guards
talevy
added a commit
to talevy/elasticsearch
that referenced
this pull request
Oct 31, 2019
this disables bwc tests for changes made in elastic#48485, that are being backported in elastic#48661. This will be reverted once elastic#48768 is merged.
Merged
talevy
added a commit
that referenced
this pull request
Oct 31, 2019
debadair
pushed a commit
to debadair/elasticsearch
that referenced
this pull request
Nov 13, 2019
this disables bwc tests for changes made in elastic#48485, that are being backported in elastic#48661. This will be reverted once elastic#48768 is merged.
debadair
pushed a commit
to debadair/elasticsearch
that referenced
this pull request
Nov 13, 2019
…stic#48768) * update IngestStats version guards to 7.6 after backporting elastic#48485 in elastic#48661, version guards in master can be updated from 8.0 to 7.6 for IngestStats serialization guards * forward port bwc tests in ingeststats * fix null ingeststats when reading the stream * re-enable bwc tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
back-port of #48485.
with an additional fix commit: