Send cluster name and discovery node in handshake #48906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits sends the cluster name and discovery naode in the transport level handshake response. This will allow us to stop sending the transport service level handshake request in the 8.0-8.x release cycle. It is necessary to start sending this in 7.x so that 8.0 is guaranteed to be communicating with a version that sends the required information..
Tim-Brooks
added
>non-issue
:Distributed/Network
|
Pinging @elastic/es-distributed (:Distributed/Network) |
|
We tried to get this in before 6.7 (#37999). But we were a little late. Now that we are close to going 7.x->8.0 it's time to reopen this PR. |
original-brownbear
approved these changes
Nov 7, 2019
server/src/main/java/org/elasticsearch/transport/TransportHandshaker.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/transport/TransportHandshaker.java
Outdated
Show resolved
Hide resolved
Tim-Brooks
added a commit
to Tim-Brooks/elasticsearch
that referenced
this pull request
Nov 8, 2019
After backporting elastic#48906 to 7.x, the new handshake response will be sent in 7.6. With this, this commit will update the version constants to reflect that change.
Tim-Brooks
added a commit
to Tim-Brooks/elasticsearch
that referenced
this pull request
Nov 8, 2019
This commits sends the cluster name and discovery naode in the transport level handshake response. This will allow us to stop sending the transport service level handshake request in the 8.0-8.x release cycle. It is necessary to start sending this in 7.x so that 8.0 is guaranteed to be communicating with a version that sends the required information.
Tim-Brooks
added a commit
that referenced
this pull request
Nov 11, 2019
After backporting #48906 to 7.x, the new handshake response will be sent in 7.6. With this, this commit will update the version constants to reflect that change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits sends the cluster name and discovery naode in the transport
level handshake response. This will allow us to stop sending the
transport service level handshake request in the 8.0-8.x release cycle.
It is necessary to start sending this in 7.x so that 8.0 is guaranteed
to be communicating with a version that sends the required information..