Make .async-search-* a restricted namespace #50294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertzaharovits
added
>enhancement
:Security/Security
|
Pinging @elastic/es-security (:Security/Security) |
tvernum
reviewed
Dec 30, 2019
...n/core/src/main/java/org/elasticsearch/xpack/core/security/index/RestrictedIndicesNames.java
Outdated
Show resolved
Hide resolved
|
@tvernum I've addressed the review comments, please take another look. |
albertzaharovits
added a commit
that referenced
this pull request
Jan 13, 2020
Hide the `.async-search-*` in Security by making it a restricted index namespace. The namespace is hard-coded. To grant privileges on restricted indices, one must explicitly toggle the `allow_restricted_indices` flag in the indices permission in the role definition. As is the case with any other index, if a certain user lacks all permissions for an index, that index is effectively nonexistent for that user.
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
Hide the `.async-search-*` in Security by making it a restricted index namespace. The namespace is hard-coded. To grant privileges on restricted indices, one must explicitly toggle the `allow_restricted_indices` flag in the indices permission in the role definition. As is the case with any other index, if a certain user lacks all permissions for an index, that index is effectively nonexistent for that user.
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ES Security hides certain indices, which should not be accessed by non-superusers.
This PR hides the
.async-search-*namespace, the same way.securityis hidden. The value of the namespace is hard-coded.I have qualms about ES Security hiding an index which is not its own. Ideally, other plugins should have the capability to register such indices, but I don't see an easy way to achieve this.
I plan to raise a follow-up that adds a new origin and system user that makes use of the new restricted index namespace. Also, the ILM origin should be adjusted (also in a follow-up) to allow ILM to work over this namespace.
PS this can also be targeted to a feature branch if this is more appropriate.
CC @jimczi
Relates #49931