Add a new async search security origin #52141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertzaharovits
added
>non-issue
:Security/Authorization
|
Pinging @elastic/es-security (:Security/Authorization) |
|
@elasticmachine run elasticsearch-ci/bwc |
tvernum
approved these changes
Feb 11, 2020
| String origin = randomFrom(ClientHelper.ML_ORIGIN, ClientHelper.WATCHER_ORIGIN, ClientHelper.DEPRECATION_ORIGIN, | ||
| ClientHelper.MONITORING_ORIGIN, ClientHelper.PERSISTENT_TASK_ORIGIN, ClientHelper.INDEX_LIFECYCLE_ORIGIN); | ||
| assertSwitchBasedOnOriginAndExecute(origin, XPackUser.INSTANCE); | ||
| for (String origin : Arrays.asList(ClientHelper.ML_ORIGIN, ClientHelper.WATCHER_ORIGIN, ClientHelper.DEPRECATION_ORIGIN, |
...ity/src/test/java/org/elasticsearch/xpack/security/authz/store/CompositeRolesStoreTests.java
Outdated
Show resolved
Hide resolved
…ecurity/authz/store/CompositeRolesStoreTests.java Co-Authored-By: Tim Vernum <tim@adjective.org>
albertzaharovits
added a commit
that referenced
this pull request
Feb 11, 2020
This commit adds a new security origin, and an associated reserved user and role, named `_async_search`, which can be used by internal clients to manage the `.async-search-*` restricted index namespace.
This is not required. Looks like the async search pllugin does not use ILM managed indices anymore. Even if it would, the ILM security origin must never be granted privileges over restricted indices because that would allow any user with privileges for ILM to interfere with restricted indices, even if it does not have privileges over restricted indices. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a new security origin, and an associated reserved user and role
_async_search, which can be used by internal clients to manage the.async-search-*restricted index namespace.I think we will also need to create a new origin for ILM since the
.async-search-*restricted indices are managed by ILM and ILM uses thexpacksecurity origin which doesn't have restricted indices privileges.CC @jimczi
Relates #49931 #50294