Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Synchronize processInStream.close() call #50581

Merged
merged 2 commits into from
Jan 3, 2020

Conversation

przemekwitek
Copy link
Contributor

@przemekwitek przemekwitek commented Jan 3, 2020

Due to https://bugs.openjdk.java.net/browse/JDK-8054565 the FilterOutputStream cannot be closed twice in Java 8.
This PR is a workaround for this issue. It needs to be merged only to 7.x branch as in master we use Java 9 which contains the proper fix.
It also unmutes testStopAndRestart test case that was suffering from the underlying issue.

Relates #49680

@przemekwitek przemekwitek added >bug :ml Machine learning v7.6.0 labels Jan 3, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

@przemekwitek przemekwitek changed the title Synchronize processInStream.close() call [7.x] Synchronize processInStream.close() call Jan 3, 2020
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Great find!

@przemekwitek przemekwitek merged commit 8917c05 into elastic:7.x Jan 3, 2020
@przemekwitek przemekwitek deleted the synchronize_stream_close branch January 3, 2020 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :ml Machine learning v7.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants