Fix AllocateRoutedStepTests reusing keys for random values #51016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In these tests there was a very small chance that keys could collide, which causes test failures. Resolves elastic#49307
dakrone
added
>non-issue
>test
|
Pinging @elastic/es-core-features (:Core/Features/ILM+SLM) |
andreidan
reviewed
Jan 15, 2020
| @@ -114,7 +114,7 @@ public void testInvalidNumberOfReplicas() { | |||
| Map<String, String> map = new HashMap<>(); | |||
| int numIncludes = randomIntBetween(minEntries, maxEntries); | |||
| for (int i = 0; i < numIncludes; i++) { | |||
| map.put(randomAlphaOfLengthBetween(1, 20), randomAlphaOfLengthBetween(1, 20)); | |||
| map.put(randomAlphaOfLengthBetween(2, 20), randomAlphaOfLengthBetween(2, 20)); | |||
There was a problem hiding this comment.
what's the reason behind this change?
There was a problem hiding this comment.
So the test that actually caused the failure generated n as the key in the map, by increasing it to at least 2, we decrease the chance of collisions. The other changes make sure we don't have collisions, but this at least decreases the amount of retries since it's less likely to collide.
|
@elasticmachine update branch |
|
user doesn't have permission to update head repository |
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Jan 15, 2020
…1016) In these tests there was a very small chance that keys could collide, which causes test failures. Resolves elastic#49307
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
…1016) In these tests there was a very small chance that keys could collide, which causes test failures. Resolves elastic#49307
droberts195
pushed a commit
to droberts195/elasticsearch
that referenced
this pull request
Mar 23, 2020
In these tests there was a very small chance that keys could collide, which causes test failures. Backport of elastic#51016
droberts195
added a commit
that referenced
this pull request
Mar 23, 2020
In these tests there was a very small chance that keys could collide, which causes test failures. Backport of #51016 Co-authored-by: Lee Hinman <dakrone@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In these tests there was a very small chance that keys could collide,
which causes test failures.
Resolves #49307