Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] AllocationRoutedStepTests testExecuteAllocateNotCompleteOnlyOneCopyAllocated failed on 7.x #49307

Closed
tlrx opened this issue Nov 19, 2019 · 3 comments · Fixed by #51016
Closed

[CI] AllocationRoutedStepTests testExecuteAllocateNotCompleteOnlyOneCopyAllocated failed on 7.x #49307

tlrx opened this issue Nov 19, 2019 · 3 comments · Fixed by #51016
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management >test-failure Triaged test failures from CI v7.7.0

Comments

@tlrx
Copy link
Member

tlrx commented Nov 19, 2019

The test AllocationRoutedStepTests testExecuteAllocateNotCompleteOnlyOneCopyAllocated failed on 7.x today: https://gradle-enterprise.elastic.co/s/x76croj3rkieo

With the error:

java.lang.AssertionError
: 
expected:<{"message":"Waiting for [1] shards to be allocated to nodes matching the given filters","shards_left_to_allocate":1,"all_shards_active":true,"actual_replicas":0}> but was:<{"message":"Waiting for [2] shards to be allocated to nodes matching the given filters","shards_left_to_allocate":2,"all_shards_active":true,"actual_replicas":0}>

It reproduces locally:

 gradlew ':x-pack:plugin:core:test' --tests "org.elasticsearch.xpack.core.ilm.AllocationRoutedStepTests.testExecuteAllocateNotCompleteOnlyOneCopyAllocated" \
  -Dtests.seed=6D0484BD7D77BE0B \
  -Dtests.security.manager=true \
  -Dtests.locale=es-ES \
  -Dtests.timezone=Europe/Copenhagen \
  -Dcompiler.java=12 \
  -Druntime.java=8
@tlrx tlrx added >test-failure Triaged test failures from CI :Data Management/ILM+SLM Index and Snapshot lifecycle management v7.6.0 labels Nov 19, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/ILM+SLM)

dakrone added a commit to dakrone/elasticsearch that referenced this issue Jan 15, 2020
@dakrone
Fix AllocateRoutedStepTests reusing keys for random values
3f1955b 
In these tests there was a very small chance that keys could collide,
which causes test failures.

Resolves elastic#49307
@dakrone dakrone mentioned this issue Jan 15, 2020
Merged
@polyfractal polyfractal added v7.7.0 and removed v7.6.0 labels Jan 15, 2020
dakrone added a commit that referenced this issue Jan 15, 2020
@dakrone
Fix AllocateRoutedStepTests reusing keys for random values (#51016)
2b79d32 
In these tests there was a very small chance that keys could collide,
which causes test failures.

Resolves #49307
dakrone added a commit to dakrone/elasticsearch that referenced this issue Jan 15, 2020
@dakrone
Fix AllocateRoutedStepTests reusing keys for random values (elastic#5…
185851c 
…1016)

In these tests there was a very small chance that keys could collide,
which causes test failures.

Resolves elastic#49307
dakrone added a commit that referenced this issue Jan 15, 2020
@dakrone
[7.x] Fix AllocateRoutedStepTests reusing keys for random valu… (#51058)
2d1c28a 
In these tests there was a very small chance that keys could collide,
which causes test failures.

Resolves #49307
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this issue Jan 23, 2020
@dakrone @SivagurunathanV
Fix AllocateRoutedStepTests reusing keys for random values (elastic#5…
d718468 
…1016)

In these tests there was a very small chance that keys could collide,
which causes test failures.

Resolves elastic#49307
@droberts195
Copy link
Contributor

The same problem is still occurring in 7.6. An example from today is https://gradle-enterprise.elastic.co/s/urn4wyju6yb54

Since the fix was just in tests, is there any reason not to cherry-pick it back to the 7.6 branch?

@droberts195
Copy link
Contributor

I opened a backport PR: #53958

Please let me know if there's a good reason not to merge it.

@n1v0lg n1v0lg mentioned this issue Jun 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management >test-failure Triaged test failures from CI v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix AllocateRoutedStepTests reusing keys for random values dakrone/elasticsearch
4 participants
@tlrx @polyfractal @droberts195 @elasticmachine