Fix NPE in PinnedQuery call to DisjunctionMaxScorer. #51047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markharwood
added
>bug
:Search/Search
|
Pinging @elastic/es-search (:Search/Search) |
jpountz
approved these changes
Jan 15, 2020
...ss-rules/src/test/java/org/elasticsearch/xpack/searchbusinessrules/PinnedQueryBuilderIT.java
Outdated
Show resolved
Hide resolved
markharwood
force-pushed
the
fix/51034
branch
from
6a54b46
to
654d5fe
Compare
Added test and fix that tests for score type. Closes elastic#51034
markharwood
force-pushed
the
fix/51034
branch
from
654d5fe
to
8986863
Compare
markharwood
added a commit
to markharwood/elasticsearch
that referenced
this pull request
Jan 16, 2020
Fix NPE in PinnedQuery call to DisjunctionMaxScorer. Added test and fix that tests for score type. Closes elastic#51034
markharwood
added a commit
that referenced
this pull request
Jan 16, 2020
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
Fix NPE in PinnedQuery call to DisjunctionMaxScorer. Added test and fix that tests for score type. Closes elastic#51034
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DisjunctionMaxScorer will throw a NullPointerException if
advanceShallowis called andscoreMode != ScoreMode.TOP_SCORES.Added code in the calling CappedScoreQuery to avoid making this call when not in the required score mode and test to reproduce the issue.