[DOCS] Include docs on permanently unreleased branches only #51743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the ability to display docs on permanently unreleased branches, such as `master` and `7.x`. Also updates how the autoscaling and EQL docs are included. Currently, these feature-flag docs would display on any unreleased branches that contain the changes, such as 7.7.
jrodewig
added
>docs
|
Pinging @elastic/es-docs (>docs) |
|
Pinging @elastic/es-distributed (:Distributed/Autoscaling) |
|
Pinging @elastic/es-search (:Search/EQL) |
jrodewig
commented
Jan 31, 2020
Comment on lines
+64
to
+69
| ifeval::["{source_branch}"=="master"] | ||
| :permanently-unreleased-branch: | ||
| endif::[] | ||
| ifeval::["{source_branch}"=="{major-version}"] | ||
| :permanently-unreleased-branch: | ||
| endif::[] |
There was a problem hiding this comment.
This is messier than preferred, but Asciidoctor does not currently support complex conditions:
asciidoctor/asciidoctor#1786
|
Thanks @jrodewig. This is a better user experience and prevents the possibility of 404s from search results for this content. |
jrodewig
added a commit
that referenced
this pull request
Feb 6, 2020
Adds the ability to display docs on permanently unreleased branches, such as `master` and `7.x`. Also updates how the autoscaling and EQL docs are included. Currently, these feature-flag docs would display on any unreleased branches that contain the changes, such as 7.7.
jrodewig
added a commit
that referenced
this pull request
Feb 7, 2020
jrodewig
added a commit
that referenced
this pull request
Feb 11, 2020
Adds the ability to display docs on permanently unreleased branches, such as `master` and `7.x`. Also updates how the autoscaling and EQL docs are included. Currently, these feature-flag docs would display on any unreleased branches that contain the changes, such as 7.7.
jrodewig
added a commit
that referenced
this pull request
Feb 11, 2020
Adds the ability to display docs on permanently unreleased branches, such as `master` and `7.x`. Also updates how the autoscaling and EQL docs are included. Currently, these feature-flag docs would display on any unreleased branches that contain the changes, such as 7.7.
|
This PR was reverted with #52066 as a potential solution for #52050. It was then discovered that this PR and that issue were unrelated. I've re-pushed the original commits for this PR to master and 7.x. This is also reflected in the backport commits comment: |
35 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to display docs on permanently unreleased branches,
such as
masterand7.x.Also updates how the autoscaling and EQL docs are included.
Currently, these feature-flag docs would display on any unreleased
branches that contain the changes, such as
7.7.