-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Display feature flag docs on master, 7.x only #52082
Conversation
Adds the ability to display docs on permanently unreleased branches, such as `master` and `7.x`. Also updates how the autoscaling and EQL docs are included. Currently, these feature-flag docs would display on any unreleased branches that contain the changes, such as 7.7.
Pinging @elastic/es-search (:Search/EQL) |
Pinging @elastic/es-docs (:Docs) |
Pinging @elastic/es-distributed (:Distributed/Autoscaling) |
/////// | ||
Permanently unreleased branches (master, n.X) | ||
/////// | ||
ifeval::["{release-state}"=="unreleased"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should prevent release build problems we saw with #52050.
@henningandersen shared the following command to test release builds:
This PR failed those tests. Unfortunately, it seems that this won't solve #52050. |
Thanks for trying this. I opened #52088 for now. |
This is a reattempt at #51743. I added some additional logic to target only non-release docs.
Adds the ability to display docs on permanently unreleased branches,
such as
master
and7.x
.Also updates how the autoscaling and EQL docs are included. Currently,
these feature-flag docs would display on any unreleased branches that
contain the changes, such as 7.7.