-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Clarifies description of num_top_feature_importance_values #52246
Conversation
Pinging @elastic/ml-core (:ml) |
Pinging @elastic/es-docs (>docs) |
e97162c
to
e202691
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that you removed the reference to the SHAP algorithm. I think it should be described somewhere in the documentation.
Furthermore, we should say that we may return less feature importance values than the parameter specifies if there are no more features available in the model or if the feature importance of other features for this document is zero.
Co-Authored-By: Valeriy Khakhutskyy <1292899+valeriy42@users.noreply.github.com>
Co-Authored-By: Valeriy Khakhutskyy <1292899+valeriy42@users.noreply.github.com>
It still exists in the pages that are linked from these API property descriptions (e.g. http://elasticsearch_52246.docs-preview.app.elstc.co/guide/en/machine-learning/master/dfa-classification.html#dfa-classification-feature-importance). |
IMO That seems like the type of information that will require further explanation and should be added in the https://www.elastic.co/guide/en/machine-learning/current/dfa-regression.html#dfa-regression-feature-importance and https://www.elastic.co/guide/en/machine-learning/current/dfa-classification.html#dfa-classification-feature-importance pages. I've created elastic/stack-docs#881 |
…2246) Co-Authored-By: Valeriy Khakhutskyy <1292899+valeriy42@users.noreply.github.com>
…2246) Co-Authored-By: Valeriy Khakhutskyy <1292899+valeriy42@users.noreply.github.com>
…astic#52246) Co-Authored-By: Valeriy Khakhutskyy <1292899+valeriy42@users.noreply.github.com>
This PR clarifies the descriptions for analysis.classification.num_top_feature_importance_values and analysis.regression.num_top_feature_importance_values in the create data frame analytics job API.
Preview: http://elasticsearch_52246.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/put-dfanalytics.html