Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Clarify feature importance values #881

Merged
merged 2 commits into from
Feb 18, 2020

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Feb 14, 2020

Related to elastic/elasticsearch#52246

This PR augments the description of feature importance in the classification and regression overview pages.

It also removes unnecessary "discrete" attributes so that we get links in the top right navigation for these long overview pages.

Preview:

Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@valeriy42 valeriy42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Well explained 👍

@lcawl lcawl merged commit 34e251d into elastic:master Feb 18, 2020
@lcawl lcawl deleted the feature-importance branch February 18, 2020 16:36
lcawl added a commit that referenced this pull request Feb 18, 2020
lcawl added a commit that referenced this pull request Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants