Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE in RestPluginsAction #52620

Merged
merged 2 commits into from
Feb 24, 2020
Merged

Fix NPE in RestPluginsAction #52620

merged 2 commits into from
Feb 24, 2020

Conversation

wangkhc
Copy link
Contributor

@wangkhc wangkhc commented Feb 21, 2020

Fix NPE in _cat/plugins api

Relates #45321

@wangkhc
Copy link
Contributor Author

wangkhc commented Feb 21, 2020

@shoulian-zhao #45321 may be fixed by this PR, please help keep notice, thank you :)

@matriv matriv added the :Data Management/CAT APIs Text APIs behind /_cat label Feb 21, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/CAT APIs)

@wangkhc
Copy link
Contributor Author

wangkhc commented Feb 21, 2020

TBR :)
@matriv @dakrone @henningandersen @debadair @dadoonet

@dakrone
Copy link
Member

dakrone commented Feb 21, 2020

@elasticmachine ok to test

@wangkhc
Copy link
Contributor Author

wangkhc commented Feb 22, 2020

@elasticmachine update branch

@wangkhc
Copy link
Contributor Author

wangkhc commented Feb 24, 2020

@dakrone Is there anything else need me to do before merging this PR? :)

dakrone
dakrone approved these changes Feb 24, 2020
View reviewed changes
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll merge this in and backport it.

@dakrone dakrone merged commit de56de9 into elastic:master Feb 24, 2020
@dakrone dakrone mentioned this pull request Feb 24, 2020
Merged
dakrone pushed a commit to dakrone/elasticsearch that referenced this pull request Feb 24, 2020
@wangkhc @elasticmachine @dakrone
fix npe in RestPluginsAction (elastic#52620)
6c39b1f 
Relates elastic#45321

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@dakrone dakrone mentioned this pull request Feb 24, 2020
Merged
dakrone pushed a commit to dakrone/elasticsearch that referenced this pull request Feb 24, 2020
@wangkhc @elasticmachine @dakrone
fix npe in RestPluginsAction (elastic#52620)
e89253f 
Relates elastic#45321

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@dakrone dakrone mentioned this pull request Feb 24, 2020
Closed
dakrone added a commit that referenced this pull request Feb 24, 2020
@dakrone @wangkhc @elasticmachine
[7.6] fix npe in RestPluginsAction (#52620) (de56de9) (#52722)
b217f31 
Relates #45321

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Kaihong.Wang <kyra.wkh@alibaba-inc.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
dakrone added a commit that referenced this pull request Feb 24, 2020
@dakrone @wangkhc @elasticmachine
[7.x] fix npe in RestPluginsAction (#52620) (de56de9) (#52721)
7d9de84 
Relates #45321

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Kaihong.Wang <kyra.wkh@alibaba-inc.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@ywelsch ywelsch changed the title fix npe in RestPluginsAction Fix NPE in RestPluginsAction Feb 28, 2020
@codebrain codebrain mentioned this pull request Apr 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakrone dakrone dakrone approved these changes

Assignees
No one assigned
Labels
>bug :Data Management/CAT APIs Text APIs behind /_cat v7.6.1 v7.7.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wangkhc @elasticmachine @dakrone @jakelandis @matriv