Make watch history indices hidden (#52962) #52974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the template used for watch history indices with the hidden index setting so that new indices will be created as hidden. Relates elastic#50251
|
Pinging @elastic/es-core-features (:Core/Features/Watcher) |
|
@gwbrown I am requesting a review because the backport was not trivial. Essentially the BWC tests failed due to watcher failing to start after the first node was upgraded. The issue is that the A side note, I noticed that the ILM/SLM template also had the same issue based on log output. It might be ok for rolling upgrades, but I figured I would mention it just in case it was not. |
The LocalIndicesCleanerTests#testHandlesWatcherHistory creates random watch history indices with a version of 1-20. When the version is 11, this matches the existing watch history template that has the index.hidden setting set to true and the check for indices in this test did not include hidden indices. The change here updates the indices options to include hidden indices. Closes elastic#53025
|
@elasticmachine run elasticsearch-ci/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the template used for watch history indices with
the hidden index setting so that new indices will be created as hidden.
Relates #50251
Backport of #52962