Highlighters skip ignored keyword values #53408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayya-sharipova
added
the
:Search Relevance/Highlighting
|
Pinging @elastic/es-search (:Search/Highlighting) |
|
TODO: for backport to 7.7, update breaking changes docs |
Keyword field values with length more than ignore_above are not indexed. But highlighters still were retrieving these values from _source and were trying to highlight them. This sometimes lead to errors if a field length exceeded max_analyzed_offset. But also this is a wrong behaviour to attempt to highlight something that was not ignored during indexing. This PR checks if a keyword value was ignored because of its length, and if yes, skips highlighting it. Closes elastic#43800
mayya-sharipova
force-pushed
the
highlighter_ignore_above
branch
from
69bd4ec
to
d0fa6d6
Compare
jimczi
reviewed
Mar 12, 2020
jimczi
approved these changes
Mar 12, 2020
mayya-sharipova
added a commit
to mayya-sharipova/elasticsearch
that referenced
this pull request
Mar 16, 2020
Keyword field values with length more than ignore_above are not indexed. But highlighters still were retrieving these values from _source and were trying to highlight them. This sometimes lead to errors if a field length exceeded max_analyzed_offset. But also this is an overall wrong behaviour to attempt to highlight something that was ignored during indexing. This PR checks if a keyword value was ignored because of its length, and if yes, skips highlighting it. Closes elastic#43800
mayya-sharipova
added a commit
that referenced
this pull request
Mar 16, 2020
Keyword field values with length more than ignore_above are not indexed. But highlighters still were retrieving these values from _source and were trying to highlight them. This sometimes lead to errors if a field length exceeded max_analyzed_offset. But also this is an overall wrong behaviour to attempt to highlight something that was ignored during indexing. This PR checks if a keyword value was ignored because of its length, and if yes, skips highlighting it. Backport: #53408 Closes #43800
38 tasks
mayya-sharipova
added a commit
to mayya-sharipova/elasticsearch
that referenced
this pull request
Jul 14, 2020
This was supposed to be done after the backport but was missed. Related to elastic#53408
mayya-sharipova
added a commit
that referenced
this pull request
Jul 14, 2020
This was supposed to be done after the backport but was missed. Related to #53408
80 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keyword field values with length more than ignore_above are not
indexed. But highlighters still were retrieving these values
from _source and were trying to highlight them. This sometimes lead to
errors if a field length exceeded max_analyzed_offset. But also this
is a wrong behaviour to attempt to highlight something that was
ignored during indexing.
This PR checks if a keyword value was ignored for indexing because of its
length, and if yes, skips highlighting it.
Closes #43800