Introduce formal role for remote cluster client #53924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduce a formal role for identifying nodes that are capable of making connections to remote clusters.
jasontedor
added
>enhancement
:Distributed/Distributed
|
Pinging @elastic/es-distributed (:Distributed/Distributed) |
|
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
rjernst
reviewed
Mar 24, 2020
| public static Set<DiscoveryNodeRole> BUILT_IN_ROLES = Set.of(DATA_ROLE, INGEST_ROLE, MASTER_ROLE); | ||
| public static Set<DiscoveryNodeRole> BUILT_IN_ROLES = Set.of(DATA_ROLE, INGEST_ROLE, MASTER_ROLE, REMOTE_CLUSTER_CLIENT_ROLE); | ||
|
|
||
| static Set<DiscoveryNodeRole> LEGACY_ROLES = Set.of(DATA_ROLE, INGEST_ROLE, MASTER_ROLE); |
There was a problem hiding this comment.
Shouldn't this be based on version? At what point would this get updated? Perhaps we could use a map of role to min version (or a predicate) and iterate over them checking each role when serializing against the version of the output stream?
There was a problem hiding this comment.
No, this shouldn't be based on version. We have two things:
- very old nodes before we made roles pluggable that only understand three roles: master, data, and ingest
- new nodes after we made roles pluggable that understand the roles they are built with us, but also understand that other nodes might send them roles that they don't understand
- for example, a 7.6.0 node today while it doesn't have a role built-in for
remote_cluster_client, does have the ability to receive that role from a 7.7.0 node, and represent it accordingly - however, a 7.0.0 node, before we made roles pluggable, has no possibility of understanding a
remote_cluster_clientrole, it would blow up if it sees it
rjernst
approved these changes
Mar 24, 2020
| public static Set<DiscoveryNodeRole> BUILT_IN_ROLES = Set.of(DATA_ROLE, INGEST_ROLE, MASTER_ROLE); | ||
| public static Set<DiscoveryNodeRole> BUILT_IN_ROLES = Set.of(DATA_ROLE, INGEST_ROLE, MASTER_ROLE, REMOTE_CLUSTER_CLIENT_ROLE); | ||
|
|
||
| static Set<DiscoveryNodeRole> LEGACY_ROLES = Set.of(DATA_ROLE, INGEST_ROLE, MASTER_ROLE); |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Mar 24, 2020
This commit introduce a formal role for identifying nodes that are capable of making connections to remote clusters.
jasontedor
added a commit
that referenced
this pull request
Mar 25, 2020
This commit introduce a formal role for identifying nodes that are capable of making connections to remote clusters. Relates #53924
This was referenced Mar 25, 2020
This was referenced Mar 25, 2020
This was referenced Apr 1, 2020
yyff
pushed a commit
to yyff/elasticsearch
that referenced
this pull request
Apr 17, 2020
This commit introduce a formal role for identifying nodes that are capable of making connections to remote clusters.
dnhatn
added a commit
that referenced
this pull request
Jul 14, 2020
) The primary shards of follower indices during the bootstrap need to be on nodes with the remote cluster client role as those nodes reach out to the corresponding leader shards on the remote cluster to copy Lucene segment files and renew the retention leases. This commit introduces a new allocation decider that ensures bootstrapping follower primaries are allocated to nodes with the remote cluster client role. Relates #54146 Relates #53924 Closes #58534 Co-authored-by: Jason Tedor <jason@tedor.me>
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Jul 14, 2020
…stic#59375) The primary shards of follower indices during the bootstrap need to be on nodes with the remote cluster client role as those nodes reach out to the corresponding leader shards on the remote cluster to copy Lucene segment files and renew the retention leases. This commit introduces a new allocation decider that ensures bootstrapping follower primaries are allocated to nodes with the remote cluster client role. Relates elastic#54146 Relates elastic#53924 Closes elastic#58534 Co-authored-by: Jason Tedor <jason@tedor.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduce a formal role for identifying nodes that are capable of making connections to remote clusters.