Assign follower primary to nodes with remote cluster client role #59375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The primary shards of follower indices during the bootstrap need to be on nodes with the remote cluster client role as those nodes reach out to the corresponding leader shards on the remote cluster to copy Lucene segment files and renew the retention leases. This commit introduces a new allocation decider that ensures those follower primaries are allocated to nodes with that role. Co-authored-by: Jason Tedor <jason@tedor.me>
dnhatn
added
>bug
:Distributed/CCR
|
Pinging @elastic/es-distributed (:Distributed/CCR) |
|
run elasticsearch-ci/2 |
jasontedor
approved these changes
Jul 13, 2020
| return allocation.decision(Decision.YES, NAME, "shard is a replica follower and is not under the purview of this decider"); | ||
| } | ||
| final RecoverySource recoverySource = shardRouting.recoverySource(); | ||
| if (recoverySource == null || recoverySource.getType() != RecoverySource.Type.SNAPSHOT) { |
|
@jasontedor Thank you for the proposal and review. |
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Jul 14, 2020
…stic#59375) The primary shards of follower indices during the bootstrap need to be on nodes with the remote cluster client role as those nodes reach out to the corresponding leader shards on the remote cluster to copy Lucene segment files and renew the retention leases. This commit introduces a new allocation decider that ensures bootstrapping follower primaries are allocated to nodes with the remote cluster client role. Relates elastic#54146 Relates elastic#53924 Closes elastic#58534 Co-authored-by: Jason Tedor <jason@tedor.me>
dnhatn
added a commit
that referenced
this pull request
Jul 14, 2020
) The primary shards of follower indices during the bootstrap need to be on nodes with the remote cluster client role as those nodes reach out to the corresponding leader shards on the remote cluster to copy Lucene segment files and renew the retention leases. This commit introduces a new allocation decider that ensures bootstrapping follower primaries are allocated to nodes with the remote cluster client role. Co-authored-by: Jason Tedor <jason@tedor.me>
albertzaharovits
pushed a commit
to albertzaharovits/elasticsearch
that referenced
this pull request
Jul 14, 2020
…stic#59375) The primary shards of follower indices during the bootstrap need to be on nodes with the remote cluster client role as those nodes reach out to the corresponding leader shards on the remote cluster to copy Lucene segment files and renew the retention leases. This commit introduces a new allocation decider that ensures bootstrapping follower primaries are allocated to nodes with the remote cluster client role. Co-authored-by: Jason Tedor <jason@tedor.me>
dnhatn
added a commit
that referenced
this pull request
Jul 15, 2020
) The primary shards of follower indices during the bootstrap need to be on nodes with the remote cluster client role as those nodes reach out to the corresponding leader shards on the remote cluster to copy Lucene segment files and renew the retention leases. This commit introduces a new allocation decider that ensures bootstrapping follower primaries are allocated to nodes with the remote cluster client role. Backport of #59375 Co-authored-by: Jason Tedor <jason@tedor.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary shards of follower indices during the bootstrap need to be
on nodes with the remote cluster client role as those nodes reach out to
the corresponding leader shards on the remote cluster to copy Lucene
segment files and renew the retention leases. This commit introduces a
new allocation decider that ensures bootstrapping follower primaries are
allocated to nodes with the remote cluster client role.
Co-authored-by: Jason Tedor jason@tedor.me
Relates #54146
Relates #53924
Closes #58534