Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify reason whenever async search gets cancelled #57761

Merged

Conversation

javanna
Copy link
Member

@javanna javanna commented Jun 5, 2020

This allows to trace where the cancel tasks request came from given that it may be triggered for multiple reasons.

This allows to trace where the cancel tasks request came from given that it may be triggered for multiple reasons.
@javanna javanna added >enhancement :Search/Search Search-related issues that do not fall into other categories v8.0.0 v7.9.0 labels Jun 5, 2020
@javanna javanna requested a review from jimczi June 5, 2020 19:02
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@elasticmachine elasticmachine added the Team:Search Meta label for search team label Jun 5, 2020
Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@javanna javanna merged commit 79aec53 into elastic:master Jun 8, 2020
javanna added a commit that referenced this pull request Jun 8, 2020
This allows to trace where the cancel tasks request came from given that it may be triggered for multiple reasons.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team v7.9.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants