Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve threadpool usage and error handling for API key validation (#58090) #59047

Merged
merged 2 commits into from
Jul 6, 2020
Merged

Improve threadpool usage and error handling for API key validation (#58090) #59047

merged 2 commits into from
Jul 6, 2020

Commits on Jul 6, 2020

  1. Improve threadpool usage and error handling for API key validation (e… 

    …lastic#58090)

The PR introduces following two changes:

Move API key validation into a new separate threadpool. The new threadpool is created separately with half of the available processors and 1000 in queue size. We could combine it with the existing TokenService's threadpool. Technically it is straightforward, but I am not sure whether it could be a rushed optimization since I am not clear about potential impact on the token service.

On threadpoool saturation, it now fails with EsRejectedExecutionException which in turns gives back a 429, instead of 401 status code to users.
    @ywangd
    ywangd committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    e305777 View commit details
    Browse the repository at this point in the history

  2. Update settings name

    @ywangd
    ywangd committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    81af475 View commit details
    Browse the repository at this point in the history