Use weekyear for WEEK_YEAR format name #60855
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates: elastic#60707 With the deprecation of camel case names in elastic#59555, the format "weekyear" was deprecated in favour of "week_year". This is inconsistent with other weekyear formats however, that use "weekyear", for example ``` WEEKYEAR_WEEK("weekyear_week"), WEEKYEAR_WEEK_DAY("weekyear_week_day"), ``` This commit keeps "weekyear" as the snake case name for the enum constant FormatNames.WEEK_YEAR. In addition, the format for DateFormatter WEEK_YEAR is changed to "weekyear".
|
I think it is already too late to make 7.9, and this change looks like it would be breaking? We need to properly deprecate usages of the snake_case version. |
pgomulka
suggested changes
Aug 17, 2020
|
btw I also plan to review and remove some of these formats. I only briefly mentioned this here #58719 |
|
closing in favour of #63384 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates: #60707
With the deprecation of camel case names in #59555,
the format "weekyear" was deprecated in favour of
"week_year". This is inconsistent with other weekyear
formats however, that use "weekyear", for example
This commit keeps "weekyear" as the snake case name
for the enum constant
FormatNames.WEEK_YEAR. In addition,the format for
DateFormatter WEEK_YEARis changed to"weekyear".
If agreed, this PR would need to be backported to 7.9 because #59555 has been merged to 7.9.