Restrict testing of legacy discovery to tests #61178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 7.x branch preserves the legacy discovery mechanism from 6.x purely for running internal cluster tests; this mechanism is otherwise completely untested and unsupported. However it is still technically possible to use it outside of the test suite if you dig through the source code to work out what settings need to be set. With this change we make it impossible to use this mechanism in production. Closes elastic#61177
DaveCTurner
added
:Distributed/Cluster Coordination
|
Pinging @elastic/es-distributed (:Distributed/Cluster Coordination) |
DaveCTurner
added a commit
that referenced
this pull request
Aug 17, 2020
The 7.x branch preserves the legacy discovery mechanism from 6.x purely for running internal cluster tests; this mechanism is otherwise completely untested and unsupported. However it is still technically possible to use it outside of the test suite if you dig through the source code to work out what settings need to be set. With this change we make it impossible to use this mechanism in production. Closes #61177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 7.x branch preserves the legacy discovery mechanism from 6.x purely
for running internal cluster tests; this mechanism is otherwise
completely untested and unsupported. However it is still technically
possible to use it if you dig through the source code to work out what
settings we set in tests. With this change we make it impossible to use
this mechanism in production.
Closes #61177