Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoscaling capacity API and structure #63905

Conversation

henningandersen
Copy link
Contributor

Renamed decision API to capacity. Responses now prefer objects/maps over
arrays. Removed mention of tier, using policies as the outer map and
total for the policy-wide total capacity.

Renamed decision API to capacity. Responses now prefer objects/maps over
arrays. Removed mention of tier, using policies as the outer map and
total for the policy-wide total capacity.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Autoscaling)

@elasticmachine elasticmachine added the Team:Distributed Meta label for distributed team label Oct 19, 2020
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with it, let's keep moving. I left one comment about the redirect, otherwise LGTM.

=== Autoscaling decision API

The autoscaling decision API has been renamed to capacity,
see <<autoscaling-get-autoscaling-capacity>>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is necessary, since we don't publish these pages for released (non-snapshot) versions? That is, today, if you navigate to this page in a snapshot version, it exists, but once we release the docs for that version, the page disappears.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I need to add this temporarily since it is referenced by the javascript api docs:

https://www.elastic.co/guide/en/elasticsearch/client/javascript-api/current/api-reference.html#_autoscaling_getautoscalingdecision

Once those have been corrected to the new link, I will circle back to remove this redirect.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, thanks for clarifying. I don't think this API should be exposed in the JavaScript client at the moment.

@henningandersen henningandersen merged commit d573fde into elastic:master Oct 21, 2020
henningandersen added a commit to henningandersen/elasticsearch that referenced this pull request Oct 21, 2020
Renamed decision API to capacity. Responses now prefer objects/maps over
arrays. Removed mention of tier, using policies as the outer map and
total for the policy-wide total capacity.
henningandersen added a commit that referenced this pull request Oct 21, 2020
Renamed decision API to capacity. Responses now prefer objects/maps over
arrays. Removed mention of tier, using policies as the outer map and
total for the policy-wide total capacity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants