-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autoscaling capacity API and structure #63905
Autoscaling capacity API and structure #63905
Conversation
Renamed decision API to capacity. Responses now prefer objects/maps over arrays. Removed mention of tier, using policies as the outer map and total for the policy-wide total capacity.
Pinging @elastic/es-distributed (:Distributed/Autoscaling) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with it, let's keep moving. I left one comment about the redirect, otherwise LGTM.
=== Autoscaling decision API | ||
|
||
The autoscaling decision API has been renamed to capacity, | ||
see <<autoscaling-get-autoscaling-capacity>>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this is necessary, since we don't publish these pages for released (non-snapshot) versions? That is, today, if you navigate to this page in a snapshot version, it exists, but once we release the docs for that version, the page disappears.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I need to add this temporarily since it is referenced by the javascript api docs:
Once those have been corrected to the new link, I will circle back to remove this redirect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, thanks for clarifying. I don't think this API should be exposed in the JavaScript client at the moment.
Renamed decision API to capacity. Responses now prefer objects/maps over arrays. Removed mention of tier, using policies as the outer map and total for the policy-wide total capacity.
Renamed decision API to capacity. Responses now prefer objects/maps over
arrays. Removed mention of tier, using policies as the outer map and
total for the policy-wide total capacity.