Fix NPE in toString of FailedShard #64770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The concatenation took precendence over the null check, leading to an NPE because `null` was passed to `ExceptionsHelper.stackTrace(failure))`.
original-brownbear
added
>non-issue
:Distributed/Allocation
|
Pinging @elastic/es-distributed (:Distributed/Allocation) |
tlrx
approved these changes
Nov 9, 2020
|
Thanks Tanguy & Henning! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Nov 9, 2020
The concatenation took precedence over the null check, leading to an NPE because `null` was passed to `ExceptionsHelper.stackTrace(failure))`.
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Nov 9, 2020
The concatenation took precedence over the null check, leading to an NPE because `null` was passed to `ExceptionsHelper.stackTrace(failure))`.
This was referenced Nov 9, 2020
original-brownbear
added a commit
that referenced
this pull request
Nov 9, 2020
original-brownbear
added a commit
that referenced
this pull request
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The concatenation took precedence over the null check, leading to an NPE
because
nullwas passed toExceptionsHelper.stackTrace(failure)).Just saw this in a test failure and it might be the cause because this kills the execution of
AllocationService#applyFailedShards