FieldTypeLookup to not implement Iterable #64983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FieldTypeLookup implements Iterable which is currently only used in IndexWarmer to iterate through all field types that have eager global ordinals set to true. Implementing Iterable makes it hard to track who iterates through all the field types. This commit exposes a new method that allows to provide a Predicate and returns an Iterable of all the field types that match the predicate.
javanna
added
:Search Foundations/Mapping
|
Pinging @elastic/es-search (:Search/Mapping) |
romseygeek
reviewed
Nov 12, 2020
| public Iterable<MappedFieldType> fieldTypes() { | ||
| return this.mapper == null ? Collections.emptySet() : this.mapper.mappers().fieldTypes(); | ||
| public Iterable<MappedFieldType> fieldTypes(Predicate<MappedFieldType> predicate) { | ||
| return this.mapper == null ? Collections.emptySet() : this.mapper.mappers().fieldTypes().filter(predicate); | ||
| } |
There was a problem hiding this comment.
Given that we only use this for index warmers, maybe we should replace this with a getEagerGlobalOrdinalsFields() method that returns a set of field names, and which calls FieldTypeLookup.filter() under the hood?
There was a problem hiding this comment.
yes I agree. will do that
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Nov 12, 2020
FieldTypeLookup implements Iterable which is currently only used in IndexWarmer to iterate through all field types that have eager global ordinals set to true. Implementing Iterable makes it hard to track who iterates through all the field types. This commit exposes a new method that allows to provide a Predicate and returns an Iterable of all the field types that match the predicate. Also, MapperService no longer exposes a way to iterate through all the field types, but rather only a specific method to iterate through the field types that have eager global ordinals.
javanna
added a commit
that referenced
this pull request
Nov 12, 2020
FieldTypeLookup implements Iterable which is currently only used in IndexWarmer to iterate through all field types that have eager global ordinals set to true. Implementing Iterable makes it hard to track who iterates through all the field types. This commit exposes a new method that allows to provide a Predicate and returns an Iterable of all the field types that match the predicate. Also, MapperService no longer exposes a way to iterate through all the field types, but rather only a specific method to iterate through the field types that have eager global ordinals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FieldTypeLookup implements Iterable which is currently only used in IndexWarmer to iterate through all field types that have eager global ordinals set to true. Implementing Iterable makes it hard to track who iterates through all the field types.
This commit exposes a new method that allows to provide a Predicate and returns an Iterable of all the field types that match the predicate.