Add support for Spatial Relationships to geo_point field #67631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iverase
added
>enhancement
:Analytics/Geo
elasticmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
talevy
approved these changes
Jan 20, 2021
|
|
||
| client().prepareIndex("test").setId("1").setSource(jsonBuilder() | ||
| .startObject() | ||
| .field(defaultGeoFieldName, "POINT(-35 -25)") |
There was a problem hiding this comment.
should this be MULTIPOINT(-35 -25)?
There was a problem hiding this comment.
The test is testing MultiPoint queries, so indexing a single point is intended. Note that unfortunately you cannot index a multipoint on a geo_point filed using WKT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In. #52382 support for geo_shape queries over geo_pint fields was added with the limitation that only INTERSECTS spatial relationships were allowed. This was mainly due to a limitation on Lucene implementation.
With the upgrade to Lucene 8.8, this limitation has been removed. Therefore this PR adds the possibility to query geo_point fields using any of the supported spatial relationships.with this change, querying geo_point or geo_shape fields should be transparent to a user as they support the same type of queries.
Note that in this PR, query processors are removed and the logic to constructs Lucene queries is moved to the Field types.