Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend socket timeout in AbstractUpgradeTestCase #69800

Conversation

DaveCTurner
Copy link
Contributor

Some test suites underneath AbstractUpgradeTestCase have a 70s timeout
when waiting for green health, which is longer than the usual socket
timeout of 60s, so a failure yields no useful information. The
longer-than-usual timeout is to allow time for delayed allocation.

This commit extends the timeout to 90s in line with other similar test
cases.

Relates #69704

Some test suites underneath `AbstractUpgradeTestCase` have a 70s timeout
when waiting for green health, which is longer than the usual socket
timeout of 60s, so a failure yields no useful information. The
longer-than-usual timeout is to allow time for delayed allocation.

This commit extends the timeout to 90s in line with other similar test
cases.

Relates elastic#69704
@DaveCTurner DaveCTurner added >test Issues or PRs that are addressing/adding tests :Core/Infra/REST API REST infrastructure and utilities v8.0.0 v7.13.0 v7.12.1 labels Mar 2, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Mar 2, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner DaveCTurner merged commit 1fcc2cb into elastic:master Mar 4, 2021
@DaveCTurner DaveCTurner deleted the 2021-02-03-longer-socket-timeout-in-upgrade-test branch March 4, 2021 09:48
DaveCTurner added a commit that referenced this pull request Mar 4, 2021
Some test suites underneath `AbstractUpgradeTestCase` have a 70s timeout
when waiting for green health, which is longer than the usual socket
timeout of 60s, so a failure yields no useful information. The
longer-than-usual timeout is to allow time for delayed allocation.

This commit extends the timeout to 90s in line with other similar test
cases.

Relates #69704
DaveCTurner added a commit that referenced this pull request Mar 4, 2021
Some test suites underneath `AbstractUpgradeTestCase` have a 70s timeout
when waiting for green health, which is longer than the usual socket
timeout of 60s, so a failure yields no useful information. The
longer-than-usual timeout is to allow time for delayed allocation.

This commit extends the timeout to 90s in line with other similar test
cases.

Relates #69704
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/REST API REST infrastructure and utilities Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests v7.12.1 v7.13.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants