Add a periodic cleanup thread for IndexFieldCache caches #7015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try { | ||
| // Each key in the cache contains an IndexFieldCache, so clean | ||
| // up each of the entries' caches | ||
| for (Key key : cache.asMap().keySet()) { |
There was a problem hiding this comment.
isn't Key#indexCache simply the same cache instance that we create on construction of IndicesFieldDataCache? We can just call cleanup once on the cache class, and then we are good?
There was a problem hiding this comment.
Ahh yea, I missed that it was threaded through and not a brand new cache, will fix.
|
LGTM, I wonder if we should be more aggressive with the interval? I think something like 60 seconds, specifically since it doesn't spawn another thread, would work well |
|
Changing the interval to 1 minute. |
|
LGTM |
clintongormley
changed the title
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defaults to every 10 minutes.
Fixes #7010